pvillard31 opened a new pull request, #10963: URL: https://github.com/apache/nifi/pull/10963
# Summary NIFI-15668 - Fail fast when RUN_ONCE is issued on an invalid processor When a `RUN_ONCE` command is issued on an invalid processor, the processor enters the `initiateStart()` retry loop which retries every 500ms waiting for the processor to become valid. Unlike a regular `RUNNING` start where this retry behavior is desirable, `RUN_ONCE` semantically means "execute right now" — if the processor can't execute, it should fail immediately. The retry loop causes the processor to get permanently stuck in the `RUN_ONCE` physical state because: - `isRunning()` returns `true` for `RUN_ONCE`, so configuration and parameter changes are rejected with "Cannot modify configuration while the Processor is running" - `getScheduledState()` returns `RUN_ONCE` (unlike `STARTING` which maps to `STOPPED` when invalid), so the API's stop handler doesn't recognize it needs to stop the processor - The stop callback that would normally fire after execution is never invoked because the processor never reaches the `trigger()` call The fix adds an early exit in `StandardProcessorNode.initiateStart()`: when the processor is not valid and the desired state is `RUN_ONCE`, it logs a warning with the validation errors and immediately returns the processor to `STOPPED` via `completeStopAction()`. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000` - [ ] Pull request contains [commits signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) with a registered key indicating `Verified` status ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `./mvnw clean install -P contrib-check` - [ ] JDK 21 - [ ] JDK 25 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
