lordgamez commented on code in PR #2129:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2129#discussion_r2884421919
##########
behave_framework/src/minifi_test_framework/core/hooks.py:
##########
@@ -57,15 +56,13 @@ def common_before_scenario(context: Context, scenario:
Scenario):
if not hasattr(context, attr):
setattr(context, attr, types.MethodType(method, context))
- logging.info("Running scenario: %s", scenario)
context.scenario_id = scenario.filename.rsplit("/", 1)[1].split(".")[0] +
"-" + str(
scenario.parent.scenarios.index(scenario))
network_name = f"{context.scenario_id}-net"
docker_client = docker.client.from_env()
try:
existing_network = docker_client.networks.get(network_name)
- logging.warning(f"Found existing network '{network_name}'. Removing it
first.")
Review Comment:
We can keep the log entries as it can be useful when running a single
scenario separately with behave. Unfortunately when running it using behavex if
the framework finds that the scenario.log file's parent directory already
exists, it creates a separate directory with a `_1` suffix making the
scenario.log and scenario.txt files appear in separate directories. That is why
the scenario_info.txt file is created in the after_scenario hook instead to
avoid this issue.
Updated in
https://github.com/apache/nifi-minifi-cpp/pull/2129/commits/13adfb355d4a12cceacd52b5d572931a610bf5eb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
