mosermw commented on PR #10957: URL: https://github.com/apache/nifi/pull/10957#issuecomment-4000188317
Great assessment @Chaffelson, thank you for doing this. I would be happy to amend this PR to remove "required = true" in these two places. I did add it where the API would return meaningless results without the presence of the parameter. I did test /nifi-api/flow/search-results without a "q" parameter and NiFi returned a valid response with no search results, so in that sense the "q" parameter is not really required. I also added "required = true" to the "file" FormParam of ProcessGroupResource.uploadProcessGroup. I suspect the Jersey FormDataParam parameters without a DefaultValue are considered required by default, so it didn't appear in your analysis. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
