lordgamez commented on code in PR #2045:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2045#discussion_r2888613141
##########
extensions/aws/processors/AwsProcessor.h:
##########
@@ -131,6 +132,11 @@ class AwsProcessor : public core::ProcessorImpl { //
NOLINT(cppcoreguidelines-s
.withValidator(core::StandardPropertyValidators::NON_BLANK_VALIDATOR)
.supportsExpressionLanguage(true)
.build();
+ EXTENSIONAPI static constexpr auto ProxyType =
core::PropertyDefinitionBuilder<magic_enum::enum_count<minifi::controllers::ProxyType>()>::createProperty("Proxy
Type")
+ .withDescription("Proxy type")
+
.withDefaultValue(magic_enum::enum_name(minifi::controllers::ProxyType::HTTP))
+
.withAllowedValues(magic_enum::enum_names<minifi::controllers::ProxyType>())
+ .build();
Review Comment:
It is also present in the controller service, but the proxy properties were
already present in the AWS processors before introducing the proxy controller
service, so this needs to be added here too. Maybe we can deprecate it in the
future and remove them to only use the proxy controller service. In NiFi 2.0
they also removed the proxy properties leaving the proxy configuration service
property. I would not suggest using the existing proxy properties for host,
port, username, password, but require adding a controller service just for the
proxy type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
