lordgamez commented on code in PR #2065: URL: https://github.com/apache/nifi-minifi-cpp/pull/2065#discussion_r2895149508
########## core-framework/include/core/controller/ControllerServiceBase.h: ########## @@ -0,0 +1,113 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +#pragma once + +#include <memory> +#include <string> +#include <utility> +#include <vector> + +#include "minifi-cpp/properties/Configure.h" +#include "core/Core.h" +#include "core/ConfigurableComponentImpl.h" +#include "core/Connectable.h" +#include "minifi-cpp/core/controller/ControllerServiceApi.h" +#include "minifi-cpp/core/controller/ControllerServiceInterface.h" +#include "minifi-cpp/core/ControllerServiceApiDefinition.h" +#include "minifi-cpp/core/controller/ControllerServiceMetadata.h" + +namespace org::apache::nifi::minifi::core::controller { + +// A base class that helps with controller service development, contains common functionalities. Review Comment: I think in this form this comment has no added value, the first part of the comment is just the reiteration of the class name, ControllerServiceBase implies that this is a base class and it is used for controller services. The second part could have added value if it was improved as you said, but looking at the interface of the class the comment seems to be trivial. I think it should be either removed or improved as you suggested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
