markap14 commented on PR #10964: URL: https://github.com/apache/nifi/pull/10964#issuecomment-4028079198
Thanks for the thorough review @awelless! I did several refactorings of this PR before pushing it, and it looks like I did a pretty poor job of cleaning up a couple of the approaches that I'd taken. Should be in much better shape now! And you caught a few interesting points that I'd not considered, as well! I pushed a new commit that I think addresses everything. Added some additional tests. Pushed 30,085,000 records to a Kinesis Stream and then consumed all using both EFO and Shared Throughput mode to ensure that all data was consumed in exactly the correct order without any duplicates and to ensure that performance was as expected. All looks good! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
