exceptionfactory commented on code in PR #10987:
URL: https://github.com/apache/nifi/pull/10987#discussion_r2911993510
##########
nifi-extension-bundles/nifi-windows-event-log-bundle/nifi-windows-event-log-processors/src/main/java/org/apache/nifi/processors/windows/event/log/ConsumeWindowsEventLog.java:
##########
@@ -64,6 +65,7 @@
@WritesAttributes({
@WritesAttribute(attribute = "mime.type", description = "Will set a
MIME type value of application/xml.")
})
+@DeprecationNotice(reason = "This processor is dependent on Windows
platform-specific operations, making it difficult to test and verify.")
Review Comment:
```suggestion
@DeprecationNotice(reason = "NIFI-15688: Depends Windows platform-specific
libraries resulting in minimal usage and maintenance since initial
implementation")
```
##########
nifi-extension-bundles/nifi-evtx-bundle/nifi-evtx-processors/src/main/java/org/apache/nifi/processors/evtx/ParseEvtx.java:
##########
@@ -63,6 +64,7 @@
@WritesAttribute(attribute = "filename", description = "The output
filename"),
@WritesAttribute(attribute = "mime.type", description = "The output
filetype (application/xml for success and failure relationships, original value
for bad chunk and original relationships)"),
})
+@DeprecationNotice(reason = "This processor is dependent on Windows
platform-specific operations, making it difficult to test and verify.")
Review Comment:
```suggestion
@DeprecationNotice(reason = "NIFI-15688: Predates Record-oriented processing
and has received minimal maintenance since initial implementation")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
