Github user alopresto commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1214#discussion_r101111449
--- Diff:
nifi-commons/nifi-utils/src/main/java/org/apache/nifi/stream/io/util/TextLineDemarcator.java
---
@@ -150,7 +126,15 @@ public OffsetInfo nextOffsetInfo(byte[] startsWith) {
return offsetInfo;
}
- private int isEol(byte currentByte, int currentIndex) {
+ /**
+ * Checks if the 'currentByte' signifies the end of the text line
(EOL);
+ * that is if the current byte's value is '\n' or '\r'. When the
+ * 'currentByte' is '\r' it will also check for the following byte to
see if
+ * it's '\n'. The returned integer value of this operation signifies
how
+ * many bytes represent the EOL and could only ever be 1 or 2 (if
--- End diff --
It could also be `0` to indicate it is not the end of line, correct?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
