martinzink opened a new pull request, #2133:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2133
This PR allows windows based docker containers to run the behave test suite
with some limitations:
- I only enabled a handful of features because some of the tests are
requiring thirdparty containers (linux only and windows doesnt allow mixed
(windows and linux) containers)
- Even the tests that dont require thirdparty containers might rely on extra
linux commands that needs to be replicated in powershell
- Its unfeasable to enable these in github CI, because this requires nested
virtualization (which is quite rare for VMs).
So this is only the MVP for this feature, but it is still a huge help for
future developments especially for using it to develop external extensions
using the upcoming C api. It cuts down the local verification time.
I've also replaced the previous m2crypto based ssl_utils with the industry
standard cryptography, this should help with the setup on macs and windows
systems (m2crypto was quite difficult to install on these systems)
---
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically main)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI
results for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
