mcgilman commented on code in PR #10698:
URL: https://github.com/apache/nifi/pull/10698#discussion_r2920078400
##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/state/current-user/current-user.effects.ts:
##########
@@ -75,6 +77,10 @@ export class CurrentUserEffects {
this.actions$.pipe(
ofType(UserActions.navigateToLogIn),
tap(() => {
+ const currentUrl = window.location.hash.substring(1) ||
this.router.url;
Review Comment:
Also I don't _think_ the `router.url` fallback here is correct. The
application is configured with `NavigationActionTiming.PostActivation` which
causes the router to not reflect until the route is activated after the guards
complete. When dispatched from a guard this value will reflect the previous URL
or undefined if it's a new window/tab.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
