exceptionfactory opened a new pull request, #10996: URL: https://github.com/apache/nifi/pull/10996
# Summary [NIFI-15568](https://issues.apache.org/jira/browse/NIFI-15568) Corrects partition by Timestamp, Date, and Time fields in the `PutIcebergRecord` Processor and the `ParquetIcebergWriter` Controller Service. Based on the initial approach in #10877, changes include selected conversion of fields with `java.sql` types to corresponding `java.time` types in the `DelegatedRecord` class. The conversion process evaluates the record schema to determine the presence of field types requiring conversion, avoiding unnecessary object creation. Instead of adding the `iceberg-data` library, which brings in additional transitive dependencies, changes to the `ParquetIcebergWriter` include a `PartitionKeyRecord` for wrapping input Iceberg `Record` objects and returning primitive partition keys following the pattern of the Iceberg [InternalRecordWrapper](https://github.com/apache/iceberg/blob/main/data/src/main/java/org/apache/iceberg/data/InternalRecordWrapper.java). New unit tests verify the behavior of the `DelegatedRecord` with Timestamp, Date, and Time fields, and also verify partition key handling for `ParquetIcebergWriter`. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000` - [X] Pull request contains [commits signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) with a registered key indicating `Verified` status ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [X] Build completed using `./mvnw clean install -P contrib-check` - [X] JDK 21 - [X] JDK 25 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
