Copilot commented on code in PR #2142:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2142#discussion_r2989879365
##########
.github/workflows/ci.yml:
##########
@@ -170,37 +170,32 @@ jobs:
- name: Support longpaths
run: git config --system core.longpaths true
- name: Checkout project
- uses: actions/checkout@v4
+ uses: actions/checkout@v6
- name: Restore cache
- uses: actions/cache/restore@v4
+ uses: actions/cache/restore@v5
with:
path: ~/AppData/Local/Mozilla/sccache/cache
key: ${{ runner.os }}-2022-sccache-${{ github.ref }}-${{ github.sha
}}
restore-keys: |
${{ runner.os }}-2022-sccache-${{ github.ref }}
${{ runner.os }}-2022-sccache-refs/heads/main
${{ runner.os }}-2022-sccache
- - name: Run sccache-cache
- uses:
mozilla-actions/sccache-action@7d986dd989559c6ecdb630a3fd2557667be217ad #
v0.0.9
- name: Set up Python
- run: choco -y install python & refreshenv
+ run: choco install -y python sccache & refreshenv
Review Comment:
In `cmd`, `&` will run `refreshenv` even if the `choco install` step fails,
which can make failures harder to diagnose and may allow subsequent steps to
run in a partially configured environment. Prefer chaining with `&&` (or
explicitly checking `%ERRORLEVEL%`) so the job fails fast on installation
errors.
```suggestion
run: choco install -y python sccache && refreshenv
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
