pvillard31 commented on code in PR #10981:
URL: https://github.com/apache/nifi/pull/10981#discussion_r3006004729


##########
nifi-extension-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch/PutElasticsearchJson.java:
##########
@@ -145,6 +165,55 @@ public class PutElasticsearchJson extends 
AbstractPutElasticsearch {
         .required(true)
         .build();
 
+    static final PropertyDescriptor MAX_BATCH_SIZE = new 
PropertyDescriptor.Builder()
+            .name("Max Batch Size")
+            .description("The maximum amount of data to send in a single 
Elasticsearch _bulk API request. " +
+                    "For NDJSON and JSON Array modes, FlowFiles are 
accumulated until this threshold is reached, then flushed. " +
+                    "For Single JSON mode, this acts as a size-based safety 
limit: if the accumulated FlowFiles exceed this size " +
+                    "before Max FlowFiles Per Batch is reached, the request is 
flushed early. " +
+                    "Elasticsearch recommends 5-15 MB per bulk request for 
optimal performance.")

Review Comment:
   Recommend using """ for multi line strings in new properties/descriptions



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to