exceptionfactory opened a new pull request, #11084: URL: https://github.com/apache/nifi/pull/11084
# Summary [NIFI-15771](https://issues.apache.org/jira/browse/NIFI-15771) Corrects the behavior of the `StandardPGPPrivateKeyService` when attempting to read a PGP Secret Key with an empty Private Key. The `gpg` command is capable exporting Secret Keys which can have an empty value for the Private Key byte array, which passes validation, resulting in a `NullPointerException` when enabling the Controller Service. The change checks for a `null` return from from [PGPSecretKey.extractPrivateKey()](https://github.com/bcgit/bc-java/blob/r1rv82/pg/src/main/java/org/bouncycastle/openpgp/PGPSecretKey.java#L696) and throws an exception indicating the empty Private Key for the Secret Key. A new unit test verifies the expected behavior, which aligns with the current implementation that requires a readable Key Ring. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000` - [X] Pull request contains [commits signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) with a registered key indicating `Verified` status ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `./mvnw clean install -P contrib-check` - [ ] JDK 21 - [ ] JDK 25 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
