martinzink commented on code in PR #2155:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2155#discussion_r3063115166


##########
extensions/sql/CMakeLists.txt:
##########
@@ -53,7 +53,7 @@ else()
         CMAKE_COMMAND ""
         UPDATE_COMMAND ""
         INSTALL_COMMAND make install
-        CONFIGURE_COMMAND ./autogen.sh && ./configure 
--prefix=${IODBC_BYPRODUCT_DIR} --with-pic
+        CONFIGURE_COMMAND ./autogen.sh && ./configure 
--prefix=${IODBC_BYPRODUCT_DIR} --with-pic CFLAGS=-std=gnu17

Review Comment:
   iodbc's configure handles these as env variables explicitly [sql add instead 
of 
overwrite](https://github.com/apache/nifi-minifi-cpp/pull/2155/commits/75ecadeb5f06ff52a7c306a67d196c10c6141141)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to