lordgamez commented on code in PR #2168: URL: https://github.com/apache/nifi-minifi-cpp/pull/2168#discussion_r3181518024
########## cmake/BundledLibcURL.cmake: ########## @@ -16,91 +16,57 @@ # under the License. function(use_bundled_curl SOURCE_DIR BINARY_DIR) Review Comment: I would remove this `use_bundled_curl` function and only include this cmake where used, also rename the removing the `Bundled` prefix to be consistent with other FetchContent using cmake files. Same for the cmake/BundledLibSSH2.cmake file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
