kevdoran opened a new pull request, #11210: URL: https://github.com/apache/nifi/pull/11210
<!-- Licensed to the Apache Software Foundation (ASF) under one or more --> <!-- contributor license agreements. See the NOTICE file distributed with --> <!-- this work for additional information regarding copyright ownership. --> <!-- The ASF licenses this file to You under the Apache License, Version 2.0 --> <!-- (the "License"); you may not use this file except in compliance with --> <!-- the License. You may obtain a copy of the License at --> <!-- http://www.apache.org/licenses/LICENSE-2.0 --> <!-- Unless required by applicable law or agreed to in writing, software --> <!-- distributed under the License is distributed on an "AS IS" BASIS, --> <!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. --> <!-- See the License for the specific language governing permissions and --> <!-- limitations under the License. --> # Summary [NIFI-15910](https://issues.apache.org/jira/browse/NIFI-15910) When a connector configuration contains a `SECRET_REFERENCE` whose fields (`fullyQualifiedSecretName`, `secretName`) are unpopulated — either because the property is gated by another property whose dependency isn't satisfied, or because it's a placeholder default emitted by an external `ConnectorConfigurationProvider` — `StandardConnectorNode` is eagerly resolving it against the SecretsManager and surfacing Property Validation - Secret Reference: The referenced secret [null] could not be found. This change makes `StandardConnectorNode.resolvePropertyReferences` (and the matching validatePropertyReferences step traversal) skip secret resolution for two cases: 1. Properties whose ConnectorPropertyDependency isn't satisfied — using the same algorithm as `AbstractConnector.isDependencySatisfied()` 2. Structurally-empty SECRET_REFERENCE values where neither FQN nor secret name is populated. Empty stubs are treated as unset, so the connector's own required-property check produces the actionable <name> is required message. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000` - Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000` - Pull request contains [commits signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) with a registered key indicating `Verified` status ### Pull Request Formatting - Pull Request based on current revision of the `main` branch - Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [x] Build completed using `./mvnw clean install -P contrib-check` - [x] JDK 21 - [ ] JDK 25 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
