martinzink commented on code in PR #2166:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2166#discussion_r3217776362
##########
libminifi/src/minifi-c.cpp:
##########
@@ -578,5 +604,40 @@ MinifiStatus MinifiProcessContextGetControllerService(
return MINIFI_STATUS_VALIDATION_FAILED;
}
+void MinifiProcessContextGetDynamicProperties(MinifiProcessContext* context,
MinifiFlowFile* minifi_flow_file,
+ void (*cb)(void* user_ctx, MinifiStringView dynamic_property_name,
MinifiStringView dynamic_property_value), void* user_ctx) {
+ gsl_Assert(context != MINIFI_NULL);
+ auto flow_file = minifi_flow_file != MINIFI_NULL ?
reinterpret_cast<std::shared_ptr<minifi::core::FlowFile>*>(minifi_flow_file)->get()
: nullptr;
+ for (auto& [key, value] :
reinterpret_cast<minifi::core::ProcessContext*>(context)->getDynamicProperties(flow_file))
{
+ cb(user_ctx, minifiStringView(key), minifiStringView(value));
+ }
+}
+
+MinifiStatus MinifiProcessContextGetSslData(MinifiProcessContext*
process_context, MinifiStringView controller_service_name,
+ void (*cb)(void* user_ctx, const MinifiSslData* ssl_data), void* user_ctx)
{
+ gsl_Assert(process_context != MINIFI_NULL);
+ const auto context =
reinterpret_cast<minifi::core::ProcessContext*>(process_context);
+ const auto name_str = std::string{toStringView(controller_service_name)};
+ const auto service_shared_ptr = context->getControllerService(name_str,
context->getProcessorInfo().getUUID());
+ if (!service_shared_ptr) { return MINIFI_STATUS_VALIDATION_FAILED; }
+ if (const auto ssl_context_service =
dynamic_cast<minifi::controllers::SSLContextServiceInterface*>(service_shared_ptr.get()))
{
+ const std::string ca_cert_file =
ssl_context_service->getCACertificate().string();
+ const std::string passphrase = ssl_context_service->getPassphrase();
+ const std::string cert_file =
ssl_context_service->getCertificateFile().string();
+ const std::string private_key_file =
ssl_context_service->getPrivateKeyFile().string();
Review Comment:
👍 [review
changes](https://github.com/apache/nifi-minifi-cpp/pull/2166/commits/f6912bf0338f652582ef04093cadbc5bee55e89c)
##########
minifi-api/include/minifi-c/minifi-c.h:
##########
@@ -41,6 +41,9 @@ extern "C" {
#define MINIFI_REGISTER_EXTENSION_FN MinifiRegisterExtension
#endif
+/// To allow the proper usage of SSLContextServices set the
MinifiPropertyDefinition::type to MINIFI_SSL_CONTEXT_SERVICE_PROPERTY_TYPE
Review Comment:
👍 [review
changes](https://github.com/apache/nifi-minifi-cpp/pull/2166/commits/f6912bf0338f652582ef04093cadbc5bee55e89c)
##########
minifi-api/include/minifi-c/minifi-c.h:
##########
@@ -253,16 +259,30 @@ size_t MinifiInputStreamSize(MinifiInputStream*);
int64_t MinifiInputStreamRead(MinifiInputStream* stream, char* buffer, size_t
size);
int64_t MinifiOutputStreamWrite(MinifiOutputStream* stream, const char* data,
size_t size);
-MinifiStatus MinifiFlowFileSetAttribute(MinifiProcessSession* session,
MinifiFlowFile* flowfile, MinifiStringView attribute_name, const
MinifiStringView* attribute_value);
-MinifiBool MinifiFlowFileGetAttribute(MinifiProcessSession* session,
MinifiFlowFile* flowfile, MinifiStringView attribute_name,
+MinifiStatus MinifiProcessSessionSetFlowFileAttribute(MinifiProcessSession*
session, MinifiFlowFile* flowfile, MinifiStringView attribute_name, const
MinifiStringView* attribute_value);
+MinifiBool MinifiProcessSessionGetFlowFileAttribute(MinifiProcessSession*
session, MinifiFlowFile* flowfile, MinifiStringView attribute_name,
void(*cb)(void* user_ctx,
MinifiStringView attribute_value), void* user_ctx);
-void MinifiFlowFileGetAttributes(MinifiProcessSession* session,
MinifiFlowFile* flowfile, void(*cb)(void* user_ctx, MinifiStringView
attribute_name, MinifiStringView attribute_value), void* user_ctx);
+void MinifiProcessSessionGetFlowFileAttributes(MinifiProcessSession* session,
MinifiFlowFile* flowfile,
+ void (*cb)(void* user_ctx, MinifiStringView attribute_name,
MinifiStringView attribute_value), void* user_ctx);
+uint64_t MinifiProcessSessionGetFlowFileSize(MinifiProcessSession* session,
MinifiFlowFile* flowfile);
+MinifiStatus MinifiProcessSessionGetFlowFileId(MinifiProcessSession* session,
MinifiFlowFile* flowfile, void(*cb)(void* user_ctx, MinifiStringView
flow_file_id), void* user_ctx);
MinifiStatus
MinifiControllerServiceContextGetProperty(MinifiControllerServiceContext*
context,
MinifiStringView property_name,
void(*cb)(void* user_ctx, MinifiStringView property_value),
void* user_ctx);
+typedef struct MinifiSslData {
+ uint8_t version;
Review Comment:
good idea, [review
changes](https://github.com/apache/nifi-minifi-cpp/pull/2166/commits/f6912bf0338f652582ef04093cadbc5bee55e89c)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
