mcgilman commented on code in PR #11225:
URL: https://github.com/apache/nifi/pull/11225#discussion_r3219356034
##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/connectors/ui/connector-table/connector-table.component.html:
##########
@@ -76,9 +76,10 @@
<div class="inline-flex items-center gap-x-2">
<span [title]="formatState(item)">{{ formatState(item)
}}</span>
@if (canRead(item) && canDiscardConfig(item)) {
- <span class="caution-color text-xs font-medium"
data-qa="edits-not-applied-badge"
- >(Edits not applied)</span
- >
+ <i
+ class="neutral-color fa fa-asterisk"
+ matTooltip="Edits not applied"
+ matTooltipPosition="after"></i>
Review Comment:
Personally, I'm not a fan of this tooltip approach.
We already show `EDITS NOT APPLIED` in the Connector card in the Connector
canvas. We probably need to align these. Assuming the Connector card also
suffers with the yellow text on white surface maybe we can consider a little
badge or something.
Thoughts?
<img width="381" height="187" alt="Image"
src="https://github.com/user-attachments/assets/a7f17764-4904-47b6-8934-48600c546848";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
