markap14 commented on code in PR #11231:
URL: https://github.com/apache/nifi/pull/11231#discussion_r3219962757
##########
nifi-framework-bundle/nifi-framework/nifi-framework-core-api/src/main/java/org/apache/nifi/components/connector/ConnectorRepository.java:
##########
@@ -89,16 +89,26 @@ public interface ConnectorRepository {
void removeConnector(String connectorId);
/**
- * Gets the Connector with the given identifier
+ * Gets the Connector with the given identifier.
+ *
* @param identifier the identifier of the Connector to get
+ * @param syncMode whether to consult the {@link
ConnectorConfigurationProvider} (if configured)
+ * to refresh local state from the external store before
returning, or whether
+ * to return the in-memory copy as-is. See {@link
ConnectorSyncMode}.
* @return the Connector with the given identifier, or null if no such
Connector exists
*/
- ConnectorNode getConnector(String identifier);
+ ConnectorNode getConnector(String identifier, ConnectorSyncMode syncMode);
Review Comment:
[claude-sonnet-4.6] `ConnectorRepository` lives in `nifi-framework-core-api`
and is an internal framework interface, not part of the public extension API in
`nifi-api`. It is not intended to be implemented by external parties, so the
same backward-compatibility constraints that apply to `nifi-api` do not apply
here.
##########
nifi-framework-bundle/nifi-framework/nifi-framework-core-api/src/main/java/org/apache/nifi/components/connector/ConnectorRepository.java:
##########
@@ -89,16 +89,26 @@ public interface ConnectorRepository {
void removeConnector(String connectorId);
/**
- * Gets the Connector with the given identifier
+ * Gets the Connector with the given identifier.
+ *
* @param identifier the identifier of the Connector to get
+ * @param syncMode whether to consult the {@link
ConnectorConfigurationProvider} (if configured)
+ * to refresh local state from the external store before
returning, or whether
+ * to return the in-memory copy as-is. See {@link
ConnectorSyncMode}.
* @return the Connector with the given identifier, or null if no such
Connector exists
*/
- ConnectorNode getConnector(String identifier);
+ ConnectorNode getConnector(String identifier, ConnectorSyncMode syncMode);
/**
+ * Returns all Connectors in the Repository.
+ *
+ * @param syncMode whether to consult the {@link
ConnectorConfigurationProvider} (if configured)
+ * to refresh each connector's local state from the
external store before
+ * returning, or whether to return the in-memory copies
as-is. See
+ * {@link ConnectorSyncMode}.
* @return all Connectors in the Repository
*/
- List<ConnectorNode> getConnectors();
+ List<ConnectorNode> getConnectors(ConnectorSyncMode syncMode);
Review Comment:
[claude-sonnet-4.6] Same as above — `ConnectorRepository` is an internal
framework interface in `nifi-framework-core-api`, not a public SPI intended for
external implementations. Backward compatibility in the `nifi-api` sense is not
required here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
