exceptionfactory commented on code in PR #11208:
URL: https://github.com/apache/nifi/pull/11208#discussion_r3261098826
##########
nifi-extension-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/yaml/YamlTreeReader.java:
##########
@@ -44,26 +46,28 @@
+ "See the Usage of the Controller Service for more information and
examples.")
public class YamlTreeReader extends JsonTreeReader {
- private static final boolean ALLOW_COMMENTS_DISABLED = false;
+ @Override
+ public void migrateProperties(PropertyConfiguration config) {
+ super.migrateProperties(config);
+
config.removeProperty(AbstractJsonRowRecordReader.PARSING_STRATEGY.getName());
Review Comment:
The `migrateProperties()` method is only needed when upgrading an existing
component, so I'm not following how the `YamlTreeReader` would need to remove
`PARSING_STRATEGY` when it has not yet been merged. Can you explain the
relationship a bit more?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
