szaszm commented on code in PR #2180: URL: https://github.com/apache/nifi-minifi-cpp/pull/2180#discussion_r3266942897
########## thirdparty/libssh2/fix-windows-ioctl.patch: ########## Review Comment: I don't think we can just patch out this ioctl without thorough testing. It changes syscall behavior. Maybe patch it out on windows only? sftp is likely broken there anyway. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
