fgerlits commented on code in PR #2107:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2107#discussion_r3280643712
##########
extensions/llamacpp/processors/RunLlamaCppInference.h:
##########
@@ -128,6 +137,8 @@ class RunLlamaCppInference : public
api::core::ProcessorImpl {
EXTENSIONAPI static constexpr auto Properties =
std::to_array<core::PropertyReference>({
ModelPath,
+ OutputAttributeName,
+ MultiModalModelPath,
Review Comment:
please add the new properties to PROCESSORS.md, too
##########
behave_framework/src/minifi_behave/steps/core_steps.py:
##########
@@ -82,6 +84,16 @@ def create_file_with_content_in_directory(context:
MinifiTestContext, directory:
context.execute_steps(f'given a directory at "{directory}" has a file with
the content "{content}" in the "{DEFAULT_MINIFI_CONTAINER_NAME}" flow')
+@step('a directory at "{directory}" has a file with the content from "{path}"')
+@step("a directory at '{directory}' has a file with the content from '{path}'")
+def create_file_with_content_in_directory(context: MinifiTestContext,
directory: str, path: str):
Review Comment:
we should keep function names unique:
```suggestion
def create_file_with_content_from_path_in_directory(context:
MinifiTestContext, directory: str, path: str):
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
