rakesh-rsky commented on PR #11275: URL: https://github.com/apache/nifi/pull/11275#issuecomment-4521256232
@sheelchand-bah Thank you for the review. Good point on API consistency. Both replace(Signal) and complete(Signal) now throw ConcurrentModificationException on concurrent modification — callers don't need to check return values. I also updated the retry loop in notify() to catch ConcurrentModificationException from replace() and continue retrying (up to MAX_REPLACE_RETRY_COUNT = 5), since that was the previous behavior when it returned false. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
