[
https://issues.apache.org/jira/browse/NIFI-3485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15868844#comment-15868844
]
ASF GitHub Bot commented on NIFI-3485:
--------------------------------------
GitHub user jjmeyer0 opened a pull request:
https://github.com/apache/nifi/pull/1514
NIFI-3485: Updated test to mock out use of InetAdress when looking up…
… domain. There was an issue where unresolvable domains got routed to an
ISP page. This should fix that issue.
To test this I mocked out I did the following:
Made the test fail by mocking InetAddress#getByName and having it throw and
exception that wasn't a `UnknownHostException`:
when(InetAddress.getByName("somenonexistentdomain.comm")).thenThrow(new
Exception("asdf"));
I then changed it to throw the expected `UnknownHostException`
when(InetAddress.getByName("somenonexistentdomain.comm")).thenThrow(UnknownHostException.class);
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jjmeyer0/nifi NIFI-3485
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1514.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1514
----
commit d82b6a2e78885737ee6b7c9e6435b002feacfcff
Author: JJ <[email protected]>
Date: 2017-02-16T00:05:28Z
NIFI-3485: Updated test to mock out use of InetAdress when looking up
domain. There was an issue where unresolvable domains got routed to an ISP
page. This should fix that issue.
----
> GeoEnrich Test that Lookups Domain Will Fail if ISP Re-routes Unresolvable
> Domains
> ----------------------------------------------------------------------------------
>
> Key: NIFI-3485
> URL: https://issues.apache.org/jira/browse/NIFI-3485
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions, Tools and Build
> Reporter: Josh Meyer
> Assignee: Josh Meyer
>
> The following test will fail if unresolvable domains get routed to a
> different page:
> https://github.com/apache/nifi/commit/3dc7a160ce83a1e83edacc54941ac4d0f5fff718#diff-ec878376fc4a20b72842315cd4d11a57R256
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
