adamdebreceni commented on code in PR #2176:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2176#discussion_r3341667871
##########
libminifi/src/minifi-c.cpp:
##########
@@ -164,7 +164,7 @@ class CControllerServiceFactory : public
minifi::core::controller::ControllerSer
return
std::make_unique<minifi::utils::CControllerService>(class_description_,
std::move(metadata));
}
- [[nodiscard]] std::string getGroupName() const override { return
group_name_; }
+ [[nodiscard]] std::string getModuleName() const override { return
group_name_; }
Review Comment:
we could also update the group_name_ as well here
##########
core-framework/include/core/ObjectFactory.h:
##########
@@ -31,7 +31,7 @@ class ObjectFactoryImpl : public ObjectFactory {
ObjectFactoryImpl() = default;
- std::string getGroupName() const override {
+ std::string getModuleName() const override {
return group_;
Review Comment:
we could also update the member
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
