rfellows commented on code in PR #11175:
URL: https://github.com/apache/nifi/pull/11175#discussion_r3343066370


##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/dao/impl/StandardProcessGroupDAO.java:
##########


Review Comment:
   To support enabling/disabling controller services for a process group in a 
connector there are a couple of changes that will need to be made in this file 
to properly locate the process group:
   
   * in `scheduleComponents`, line 305 should probably be:
   ```java
           final ProcessGroup group = locateProcessGroup(flowController, 
groupId, true);
   ```
   
   * in `activateControllerServices`, line 414 should probably be:
   ```java
           final ProcessGroup group = locateProcessGroup(flowController, 
groupId, true);
   ```
   
   Otherwise, the lookup fails with a 400 error indicating it "Cannot activate 
Controller Services with IDs [] because the associated Process Group 
(id=<<pgid>>) could not be found"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to