Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/1436
This is really cool and I suspect these processors will get a lot of use.
Some feedback below.
TransformCSVtoJSON:
1) It needs to set the content type attribute. Aids content viewing and
routing decisions. For example
flowFile = session.putAttribute(flowFile,
CoreAttributes.MIME_TYPE.key(), "application/json");
UpdateAttributeWithSchema:
1) Recommend changing the name to 'ExtractSchema'. The name is confusing
when you consider 'UpdateAttribute' processor and what that one does (and is
very common).
2) It grabs the schema definition from the registry service and makes that
a flow file attribute. This is problematic if the schema is large. We do not
want large flow file attributes. So this needs to be limited. Why is this
processor needed?
TransformJSONToAvro:
1) Needs to set the content type attribute. According to the latest avro
spec it is "avro/binary"
TransformAvroToCSV
1) Needs to set the content type attribute. "text/csv"
TransformCSVToAvro
1) Needs to set the content type attribute.
TransformAvroToJson
1) Needs to set the content type attribute.
TransformJSONToCSV
1) Needs to set the content type attribute.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
