martinzink commented on code in PR #2175:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2175#discussion_r3346969453
##########
extensions/kafka/ConsumeKafka.cpp:
##########
@@ -180,15 +131,15 @@ void
ConsumeKafka::configureNewConnection(core::ProcessContext& context) {
setKafkaConfigurationField(*conf_, "enable.auto.offset.store",
std::to_string(commit_policy_ == consume_kafka::CommitPolicyEnum::AutoCommit));
setKafkaConfigurationField(*conf_, "isolation.level",
utils::parseBoolProperty(context, HonorTransactions) ? "read_committed" :
"read_uncommitted");
setKafkaConfigurationField(*conf_, "group.id", utils::parseProperty(context,
GroupID));
- setKafkaConfigurationField(*conf_, "client.id", this->getUUIDStr());
+ // setKafkaConfigurationField(*conf_, "client.id", client_id); No need to
set id since its autogenerated, and we don't access it anywhere from minifi
Review Comment:
it turns out we have the processor id so nevermind reverted in [readd
setKafkaConfigurationField(*conf_, "client.id",
this->getUUIDSt…](https://github.com/apache/nifi-minifi-cpp/pull/2175/commits/4219fd84efe47ec6894478e282bdbecd9cd6acb4)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
