scottyaslan commented on code in PR #11262: URL: https://github.com/apache/nifi/pull/11262#discussion_r3351497961
########## nifi-frontend/src/main/frontend/libs/shared/src/assets/themes/components/_option.scss: ########## @@ -0,0 +1,33 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +@use '@angular/material' as mat; + +@mixin generate-material-theme() { + :root { + .mat-mdc-option[disabled] { Review Comment: It is unfortunate but the PR that introduced the searchable-select and mult-select-option components fundamentally changed all mat-select options throughout the nifi design system. This we erroneously merged as the mult-select-options are just mat-options and should inherit from the same spec as mat-option. What we need to do is to restore the mat-options to their correct behavior (mostly default angular material) and instead update the searchable-select and mult-select-option components to accordingly inherit from those. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
