pvillard31 commented on code in PR #11314:
URL: https://github.com/apache/nifi/pull/11314#discussion_r3398749016
##########
nifi-extension-bundles/nifi-snowflake-bundle/nifi-snowflake-services/src/main/java/org/apache/nifi/snowflake/service/StandardSnowflakeIngestManagerProviderService.java:
##########
@@ -213,6 +228,46 @@ public void migrateProperties(PropertyConfiguration
config) {
config.renameProperty(SnowflakeProperties.OLD_SCHEMA_PROPERTY_NAME,
SnowflakeProperties.SCHEMA.getName());
}
+ private ProxySelector buildProxySelector(final ProxyConfigurationService
proxyConfigurationService) {
+ if (proxyConfigurationService == null) {
+ return null;
+ }
+ final Proxy proxy =
proxyConfigurationService.getConfiguration().createProxy();
+ // Use a custom ProxySelector so that the Proxy.Type (HTTP or SOCKS)
is preserved,
Review Comment:
The JDK java.net.http.HttpClient only applies HTTP proxies and ignores a
SOCKS Proxy, so a configured SOCKS proxy would silently fall back to a direct
connection. Should we drop the SOCKS handling claim or validate that only HTTP
proxy types are configured?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
