markap14 commented on PR #11325: URL: https://github.com/apache/nifi/pull/11325#issuecomment-4694575420
[claude-opus-4.7] Thanks for the review, @KevDoran! Addressed in `3d0350401bf`: **#1 — missing `@return`:** added the `@return` tag on `NiFiProperties#getClusterNodeProtocolHttpVersion`. **#2 — admin-guide scope note / #4 — track the stopgap:** taking a slightly different tack on these. Since this property is not intended as a long-term supported configuration knob (the goal is for it to disappear once the upstream Jetty 12.1.10 `RST_STREAM` regression is resolved), I removed the entry from the administration guide entirely rather than document it. To keep the trail visible to future maintainers, I added a comment block above the `nifi.cluster.node.protocol.http.version=HTTP_1_1` line in each system-test `conf/*/nifi.properties` template explaining that the override is a short-term workaround for the Jetty 12.1.10 HTTP/2 stream-reset rewrite ([jetty/jetty.project#15087](https://github.com/jetty/jetty.project/pull/15087)) and should be removed once Jetty is fixed. **#3 — case-insensitive parsing:** leaving the strict `HttpClient.Version.valueOf(...)` for now. Since this isn't a setting we want operators to be relying on, I think surfacing typos via the existing warn-and-fall-back-to-`HTTP_2` path is the better behavior; happy to revisit if you feel strongly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
