dan-s1 commented on code in PR #11338:
URL: https://github.com/apache/nifi/pull/11338#discussion_r3421833087
##########
nifi-extension-bundles/nifi-jslt-bundle/nifi-jslt-processors/src/main/java/org/apache/nifi/processors/jslt/JSLTTransformJSON.java:
##########
@@ -430,9 +429,9 @@ private String readTransform(final PropertyValue
propertyValue) {
return propertyValue.getValue();
}
try (final BufferedReader reader = new BufferedReader(new
InputStreamReader(resourceReference.read()))) {
- return reader.lines().collect(Collectors.joining());
+ return
reader.lines().collect(Collectors.joining(System.lineSeparator()));
Review Comment:
I did not consider that. I made the same change as was made in #7678 for
JoltTransformJSON and JoltTransformRecord which solved the similar issue. Do
still want this change? If so should a similar change then be made for
JoltTransformJSON and JoltTransformRecord?
##########
nifi-extension-bundles/nifi-jslt-bundle/nifi-jslt-processors/src/main/java/org/apache/nifi/processors/jslt/JSLTTransformJSON.java:
##########
@@ -430,9 +429,9 @@ private String readTransform(final PropertyValue
propertyValue) {
return propertyValue.getValue();
}
try (final BufferedReader reader = new BufferedReader(new
InputStreamReader(resourceReference.read()))) {
- return reader.lines().collect(Collectors.joining());
+ return
reader.lines().collect(Collectors.joining(System.lineSeparator()));
Review Comment:
I did not consider that. I made the same change as was made in #7678 for
`JoltTransformJSON` and `JoltTransformRecord` which solved the similar issue.
Do still want this change? If so should a similar change then be made for
JoltTransformJSON and JoltTransformRecord?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
