markap14 commented on PR #11201: URL: https://github.com/apache/nifi/pull/11201#issuecomment-4801066716
Thanks @exceptionfactory. @adwk67 I have a couple of concerns here. Firstly, the lifecycle management of components that need to be updated should be happening higher up the call stack, in the `public void synchronize(final ProcessGroup group, final VersionedExternalFlow versionedExternalFlow, final FlowSynchronizationOptions options)` method. The intent here is to ensure that anything that will be modified is stopped at the start so that everything is in a good state before we start changing any of the components. Secondly, I'm struggling to fully understand what the issue is. The Jira states: > When the proposed flow adds a controller service at a child group level with the same identifier as an existing ENABLED service at the root level... and > Steps to reproduce > Deploy a 2-node NiFi cluster with a flow where the same CS identifier appears at root group level and child group level. But we should never have multiple components with the same identifier. Can you explain the steps necessary to get into this scenario to start with? If we have multiple components with the same id, that sounds like the source of the problem, rather than how we handle the synchronization. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
