[ 
https://issues.apache.org/jira/browse/NIFI-16050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Stieglitz updated NIFI-16050:
------------------------------------
    Description: 
In DtoFactory on lines 1481-1486 and lines 1487-1492 there is a duplicated 
block of code  as seen below:
{code:java}
// if this port is remotely accessible, determine if its actually connected to 
another nifi
        if (port instanceof PublicPort) {
            final PublicPort publicPort = (PublicPort) port;
            dto.setAllowRemoteAccess(true);
            dto.setTransmitting(publicPort.isTransmitting());
        }
// if this port is remotely accessible, determine if its actually connected to 
another nifi
        if (port instanceof PublicPort) {
            final PublicPort publicPort = (PublicPort) port;
            dto.setAllowRemoteAccess(true);
            dto.setTransmitting(publicPort.isTransmitting());
        }{code}
The aim of this ticket is to remove the second block. 

  was:
In DtoFactory on lines 1481-1486 and lines 1487-1492 there is a duplicated 
block of code  as seen below:
{code:java}
// if this port is remotely accessible, determine if its actually connected to 
another nifi
        if (port instanceof PublicPort) {
            final PublicPort publicPort = (PublicPort) port;
            dto.setAllowRemoteAccess(true);
            dto.setTransmitting(publicPort.isTransmitting());
        }
        // if this port is remotely accessible, determine if its actually 
connected to another nifi
        if (port instanceof PublicPort) {
            final PublicPort publicPort = (PublicPort) port;
            dto.setAllowRemoteAccess(true);
            dto.setTransmitting(publicPort.isTransmitting());
        }{code}
The aim of this ticket is to remove the second block. 


> Remove duplicated code in DtoFactory
> ------------------------------------
>
>                 Key: NIFI-16050
>                 URL: https://issues.apache.org/jira/browse/NIFI-16050
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Daniel Stieglitz
>            Assignee: Daniel Stieglitz
>            Priority: Minor
>
> In DtoFactory on lines 1481-1486 and lines 1487-1492 there is a duplicated 
> block of code  as seen below:
> {code:java}
> // if this port is remotely accessible, determine if its actually connected 
> to another nifi
>         if (port instanceof PublicPort) {
>             final PublicPort publicPort = (PublicPort) port;
>             dto.setAllowRemoteAccess(true);
>             dto.setTransmitting(publicPort.isTransmitting());
>         }
> // if this port is remotely accessible, determine if its actually connected 
> to another nifi
>         if (port instanceof PublicPort) {
>             final PublicPort publicPort = (PublicPort) port;
>             dto.setAllowRemoteAccess(true);
>             dto.setTransmitting(publicPort.isTransmitting());
>         }{code}
> The aim of this ticket is to remove the second block. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to