ChrisSamo632 commented on code in PR #11355:
URL: https://github.com/apache/nifi/pull/11355#discussion_r3488418698
##########
nifi-extension-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch/PutElasticsearchJson.java:
##########
@@ -241,6 +241,11 @@ public class PutElasticsearchJson extends
AbstractPutElasticsearch {
.name("Identifier Field")
.description("""
The name of the field within each document to use as the
Elasticsearch document ID. \
+ A nested field can be referenced with a "/"-delimited
path: for a document \
Review Comment:
Thinking about the `.` suggestion a little more - I'd be concerned with
someone using that and *not* having the field removed from the json by the
processor before it was indexed, which is more likely to run into problems on
the Elasticsearch side
So maybe the best idea is to stick with `/` (to be nifi record path-like),
and offer a property that uses it as a nested field delimiter (allowing for `\`
escaping as needed), or as a literal (the default for backwards compatibility)
What do you think @agturley ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
