kevdoran opened a new pull request, #11380: URL: https://github.com/apache/nifi/pull/11380
<!-- Licensed to the Apache Software Foundation (ASF) under one or more --> <!-- contributor license agreements. See the NOTICE file distributed with --> <!-- this work for additional information regarding copyright ownership. --> <!-- The ASF licenses this file to You under the Apache License, Version 2.0 --> <!-- (the "License"); you may not use this file except in compliance with --> <!-- the License. You may obtain a copy of the License at --> <!-- http://www.apache.org/licenses/LICENSE-2.0 --> <!-- Unless required by applicable law or agreed to in writing, software --> <!-- distributed under the License is distributed on an "AS IS" BASIS, --> <!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. --> <!-- See the License for the specific language governing permissions and --> <!-- limitations under the License. --> # Summary [NIFI-16060](https://issues.apache.org/jira/browse/NIFI-16060) When a connector's stored configuration cannot be loaded or parsed (e.g. a corrupt config left behind by a failed commit), the ConnectorConfigurationProvider throws ConnectorConfigurationProviderException. On the SYNC_WITH_PROVIDER read path this exception previously propagated uncaught and surfaced as an HTTP 500 from the connector REST endpoints. Because the delete flow reads the connector (for its revision, and to snapshot it before deletion), a corrupt connector became impossible to read or delete. Make the two read retrieval methods (getConnector and getConnectors with SYNC_WITH_PROVIDER) tolerate a configuration-load failure: log a warning, mark the connector invalid so the failure remains visible to clients via the DTO's validation status, and return the in-memory node instead of propagating. The connector therefore stays readable and deletable. Write paths (addConnector, applyUpdate) call syncFromProvider directly and continue to propagate the exception, so create/apply-config still fail on a bad configuration rather than proceeding silently. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000` - Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000` - Pull request contains [commits signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) with a registered key indicating `Verified` status ### Pull Request Formatting - Pull Request based on current revision of the `main` branch - Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [x] Build completed using `./mvnw clean install -P contrib-check` - [x] JDK 21 - [ ] JDK 25 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
