exceptionfactory commented on code in PR #100:
URL: https://github.com/apache/nifi-api/pull/100#discussion_r3529804067
##########
src/main/java/org/apache/nifi/registry/flow/AbstractFlowRegistryClient.java:
##########
@@ -17,13 +17,31 @@
package org.apache.nifi.registry.flow;
import org.apache.nifi.components.AbstractConfigurableComponent;
+import org.apache.nifi.components.PropertyDescriptor;
import org.apache.nifi.logging.ComponentLog;
+import org.apache.nifi.processor.util.StandardValidators;
import java.util.Optional;
import javax.net.ssl.SSLContext;
public abstract class AbstractFlowRegistryClient extends
AbstractConfigurableComponent implements FlowRegistryClient {
+ /**
+ * Property that controls how often NiFi checks this Flow Registry Client
for updated versions of the flows that
+ * are under version control against it. When this property is left blank,
NiFi falls back to the global
+ * {@code nifi.flowcontroller.registry.sync.interval} property. Concrete
Flow Registry Client implementations should
+ * include this descriptor in the List returned by {@link
#getSupportedPropertyDescriptors()} in order to allow the
+ * synchronization interval to be configured on a per-client basis.
+ */
+ public static final PropertyDescriptor SYNCHRONIZATION_INTERVAL = new
PropertyDescriptor.Builder()
+ .name("Synchronization Interval")
+ .description("""
+ How often NiFi checks this Flow Registry Client for newer
versions of the flows that are under version control against it.\s\
Review Comment:
This `\s\` string looks extraneous
##########
src/main/java/org/apache/nifi/registry/flow/AbstractFlowRegistryClient.java:
##########
@@ -17,13 +17,31 @@
package org.apache.nifi.registry.flow;
import org.apache.nifi.components.AbstractConfigurableComponent;
+import org.apache.nifi.components.PropertyDescriptor;
import org.apache.nifi.logging.ComponentLog;
+import org.apache.nifi.processor.util.StandardValidators;
import java.util.Optional;
import javax.net.ssl.SSLContext;
public abstract class AbstractFlowRegistryClient extends
AbstractConfigurableComponent implements FlowRegistryClient {
+ /**
+ * Property that controls how often NiFi checks this Flow Registry Client
for updated versions of the flows that
+ * are under version control against it. When this property is left blank,
NiFi falls back to the global
+ * {@code nifi.flowcontroller.registry.sync.interval} property. Concrete
Flow Registry Client implementations should
+ * include this descriptor in the List returned by {@link
#getSupportedPropertyDescriptors()} in order to allow the
+ * synchronization interval to be configured on a per-client basis.
+ */
+ public static final PropertyDescriptor SYNCHRONIZATION_INTERVAL = new
PropertyDescriptor.Builder()
+ .name("Synchronization Interval")
+ .description("""
+ How often NiFi checks this Flow Registry Client for newer
versions of the flows that are under version control against it.\s\
+ When left blank, the global
nifi.flowcontroller.registry.sync.interval property is used.""")
Review Comment:
```suggestion
When left blank, the application uses the
nifi.flowcontroller.registry.sync.interval property""")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
