exceptionfactory commented on code in PR #11397:
URL: https://github.com/apache/nifi/pull/11397#discussion_r3533082148
##########
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/UpdateDatabaseTable.java:
##########
@@ -537,14 +537,14 @@ private synchronized OutputMetadataHolder
checkAndUpdateTableSchema(
}
final int dataType =
DataTypeUtils.getSQLTypeValue(recordField.getDataType());
- final String quotedColumnName =
enquoteIdentifier(columnName, quoteString, quoteColumnNames);
+ final String quotedColumnName = enquoteIdentifier(s,
columnName, quoteColumnNames);
columns.add(new ColumnDescription(quotedColumnName,
dataType, required, null, recordField.isNullable()));
getLogger().debug("Adding column {} to table {}",
columnName, tableName);
}
- final String quotedCatalogName =
enquoteIdentifier(catalogName, quoteString, quoteTableName);
- final String quotedSchemaName =
enquoteIdentifier(schemaName, quoteString, quoteTableName);
- final String quotedTableName =
enquoteIdentifier(tableName, quoteString, quoteTableName);
+ final String quotedCatalogName = enquoteIdentifier(s,
catalogName, quoteTableName);
+ final String quotedSchemaName = enquoteIdentifier(s,
schemaName, quoteTableName);
+ final String quotedTableName = enquoteIdentifier(s,
tableName, quoteTableName);
tableSchema = new TableSchema(quotedCatalogName,
quotedSchemaName, quotedTableName, columns, translateFieldNames, normalizer,
primaryKeyColumnNames, quoteString);
Review Comment:
The only use of the `quotedIdentifierString` is in `PutDatabaseRecord`, and
seems better to handle that separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
