Github user patricker commented on the issue:

    https://github.com/apache/nifi/pull/1510
  
    @stanislavprokopov Thoughts on how I can distinguish that this adapter is 
only for MS SQL v2012 or greater? Right now Database Adapters don't have a 
description, but I could add a field, populate it for all of them, and show it 
on the Adapter drop down list.
    
    I don't understand how I could get around setting ORDER BY when just using 
TOP, assuming I will have additional pages of data.  Can you show me an example 
of what Page 1 (TOP) and Page 2 (OFFSET) queries would look like such that they 
will work together?
    
    If you meant that there will be no paging and only TOP will be used, then 
the code already supports this without an ORDER BY:
    
    ```
    if (limit != null && offset == null){
                 query.append("TOP ");
                 query.append(limit);
                 query.append(" ");
             }
    ```
    The ORDER BY check only kicks in if `offset` also does not equal `null`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to