IPL opened a new pull request, #11513: URL: https://github.com/apache/nifi/pull/11513
<!-- Licensed to the Apache Software Foundation (ASF) under one or more --> <!-- contributor license agreements. See the NOTICE file distributed with --> <!-- this work for additional information regarding copyright ownership. --> <!-- The ASF licenses this file to You under the Apache License, Version 2.0 --> <!-- (the "License"); you may not use this file except in compliance with --> <!-- the License. You may obtain a copy of the License at --> <!-- http://www.apache.org/licenses/LICENSE-2.0 --> <!-- Unless required by applicable law or agreed to in writing, software --> <!-- distributed under the License is distributed on an "AS IS" BASIS, --> <!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. --> <!-- See the License for the specific language governing permissions and --> <!-- limitations under the License. --> # Summary [NIFI-16125](https://issues.apache.org/jira/browse/NIFI-16125) `FlowController.initializeFlow()` performs the initial validation of every component (Controller Services, Reporting Tasks, Flow Analysis Rules, Parameter Providers, Processors, Flow Registry Clients, and Connectors) sequentially on a single thread via `TriggerValidationTask`. For flows with a large number of components, this can make up a significant portion of startup time. This PR adds an optional `ExecutorService` parameter to `TriggerValidationTask`. When supplied, each component's validation is submitted to the executor instead of being validated one at a time on the calling thread; `FlowController` now passes its existing `validationThreadPool` (already used for periodic re-validation and `triggerAsync`) for the initial validation performed at startup. Validating distinct components concurrently is safe because each `ComponentNode` tracks its own validation state independently, and the framework already allows concurrent `trigger()` calls from different threads via `triggerAsync()` on the same pool. A new `isValidationComplete()` accessor reports whether the most recent run actually validated every component. It returns `false` if the run was interrupted, or the executor rejected work, before every component could be validated — `FlowController` logs a warning in that case instead of unconditionally logging success, avoiding a silent partial-completion that the previous implementation would not have surfaced. Unit tests were added covering the serial path (unchanged behavior), the parallel happy path, executor rejection, and interruption while awaiting completion. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000` - Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000` - Pull request contains [commits signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) with a registered key indicating `Verified` status ### Pull Request Formatting - Pull Request based on current revision of the `main` branch - Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `./mvnw clean install -P contrib-check` - [ ] JDK 21 - [ ] JDK 25 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
