pvillard31 commented on code in PR #11530: URL: https://github.com/apache/nifi/pull/11530#discussion_r3765057534
########## nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/java/org/apache/nifi/controller/queue/clustered/client/async/nio/TestStandardPeerChannelProvider.java: ########## @@ -0,0 +1,123 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.nifi.controller.queue.clustered.client.async.nio; + +import org.apache.nifi.cluster.protocol.NodeIdentifier; +import org.apache.nifi.security.cert.builder.StandardCertificateBuilder; +import org.apache.nifi.security.ssl.EphemeralKeyStoreBuilder; Review Comment: TestStandardPeerChannelProvider uses classes from nifi-security-ssl, but this module currently receives that artifact transitively. Should we add an explicit test-scope dependency? ########## nifi-system-tests/nifi-system-test-suite/src/test/java/org/apache/nifi/tests/system/loadbalance/LoadBalanceIT.java: ########## @@ -354,7 +354,7 @@ public void testRoundRobinWithRestartAndPortChange() throws NiFiClientException, instance2.stop(); final Map<String, String> updatedLoadBalanceProperties = new HashMap<>(); - updatedLoadBalanceProperties.put("nifi.cluster.load.balance.host", "127.0.0.1"); + updatedLoadBalanceProperties.put("nifi.cluster.load.balance.host", "localhost"); Review Comment: The administration guide currently allows a hostname or IP address, but endpoint identification requires the configured value to match a DNS or IP Subject Alternative Name in the peer certificate. Can we document this upgrade requirement for nifi.cluster.load.balance.host and its nifi.cluster.node.address fallback? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
