Copilot commented on code in PR #2248:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2248#discussion_r3807116322
##########
.github/workflows/ci.yml:
##########
@@ -17,8 +17,17 @@ env:
-DENABLE_ELASTICSEARCH=ON -DENABLE_GRAFANA_LOKI=ON -DENABLE_COUCHBASE=ON
-DENABLE_LLAMACPP=ON -DDOCKER_BUILD_ONLY=ON -DMINIFI_PERFORMANCE_TESTS=ON
-DMINIFI_RUST=OFF -DDOCKER_USE_CONAN=ON \
-DDOCKER_NIFI_CONAN_USER=${{ secrets.CONAN_USERNAME }}
-DDOCKER_NIFI_CONAN_PASSWORD=${{ secrets.CONAN_ACCESS_TOKEN }}
jobs:
+ check_trigger:
+ if: >-
+ github.event_name != 'push' ||
+ github.repository != 'apache/nifi-minifi-cpp' ||
+ github.ref == 'refs/heads/main'
Review Comment:
This does not prevent the suppressed `push` workflow run from entering the
workflow-level concurrency group. For an Apache branch, that group is identical
to the corresponding `pull_request` run's group, so a later skipped push run
can still cancel the real PR CI because `cancel-in-progress` is enabled. Give
suppressed pushes a distinct concurrency key (or prevent the workflow run from
being created) so they cannot cancel PR validation.
##########
.github/workflows/ci.yml:
##########
@@ -17,8 +17,17 @@ env:
-DENABLE_ELASTICSEARCH=ON -DENABLE_GRAFANA_LOKI=ON -DENABLE_COUCHBASE=ON
-DENABLE_LLAMACPP=ON -DDOCKER_BUILD_ONLY=ON -DMINIFI_PERFORMANCE_TESTS=ON
-DMINIFI_RUST=OFF -DDOCKER_USE_CONAN=ON \
-DDOCKER_NIFI_CONAN_USER=${{ secrets.CONAN_USERNAME }}
-DDOCKER_NIFI_CONAN_PASSWORD=${{ secrets.CONAN_ACCESS_TOKEN }}
jobs:
+ check_trigger:
+ if: >-
+ github.event_name != 'push' ||
+ github.repository != 'apache/nifi-minifi-cpp' ||
+ github.ref == 'refs/heads/main'
Review Comment:
The condition suppresses every non-`main` push in the Apache repository, not
only duplicate pushes for branches with PRs. This also removes CI from tag
pushes and direct pushes to maintenance/release branches that were covered by
the unfiltered `push` trigger before this change. The gate needs to preserve
non-PR push validation while excluding only the duplicate PR case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
