exceptionfactory commented on code in PR #11242:
URL: https://github.com/apache/nifi/pull/11242#discussion_r3821990479
##########
nifi-extension-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/test/java/org/apache/nifi/amqp/processors/PublishAMQPTest.java:
##########
@@ -181,7 +210,42 @@ public void validateFailedPublishAndTransferToFailure() {
runner.run();
assertTrue(runner.getFlowFilesForRelationship(PublishAMQP.REL_SUCCESS).isEmpty());
-
assertNotNull(runner.getFlowFilesForRelationship(PublishAMQP.REL_FAILURE).getFirst());
+ final MockFlowFile failureFlowFile =
runner.getFlowFilesForRelationship(PublishAMQP.REL_FAILURE).getFirst();
+ assertNotNull(failureFlowFile);
+ assertFalse(failureFlowFile.isPenalized());
+ runner.assertPenalizeCount(0);
+ }
+
+ @Test
+ public void
validateOversizedFlowFileTransferredToFailureWithoutPublishing() throws
Exception {
+ setConnectionProperties(runner);
+ runner.setProperty(PublishAMQP.MAXIMUM_INPUT_FLOWFILE_SIZE, "4 B");
+
+ runner.enqueue("Hello".getBytes());
+
+ runner.run();
+
+
assertTrue(runner.getFlowFilesForRelationship(PublishAMQP.REL_SUCCESS).isEmpty());
+ final MockFlowFile failureFlowFile =
runner.getFlowFilesForRelationship(PublishAMQP.REL_FAILURE).getFirst();
+ assertNotNull(failureFlowFile);
+ assertFalse(failureFlowFile.isPenalized());
+ runner.assertPenalizeCount(0);
+
+ final Channel channel = pubProc.getConnection().createChannel();
+ assertNull(channel.basicGet("queue1", true));
+ }
+
+ @Test
+ public void validateMaximumInputFlowFileSizeProperty() {
+ assertEquals("Maximum Input FlowFile Size",
PublishAMQP.MAXIMUM_INPUT_FLOWFILE_SIZE.getName());
+ assertEquals("128 MB",
PublishAMQP.MAXIMUM_INPUT_FLOWFILE_SIZE.getDefaultValue());
+
+ setConnectionProperties(runner);
+ runner.setProperty(PublishAMQP.MAXIMUM_INPUT_FLOWFILE_SIZE, "128 MB");
+ runner.assertValid();
+
+ runner.setProperty(PublishAMQP.MAXIMUM_INPUT_FLOWFILE_SIZE, "129 MB");
+ runner.assertNotValid();
}
Review Comment:
This test method is failing, but it should be removed since it is simply
evaluating property descriptor values
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
