exceptionfactory opened a new pull request, #11577: URL: https://github.com/apache/nifi/pull/11577
# Summary [NIFI-16230](https://issues.apache.org/jira/browse/NIFI-16230) Corrects the lifecycle handling of the `StandardRebalancingPartition` with particular focus on the Thread behavior of the `RebalanceTask`. The changes refactor the `RebalanceTask` from a persistent `Thread` to an executable command managed through a `ThreadPoolExecutor` with a size of one Thread. With this restructuring, the `RebalanceTask` continues running while data remains in the FlowFile Queue, and stops running upon completion. Together with the allow core thread time out setting on the `ThreadPoolExecutor`, this approach involves short-lived tasks versus a long-running Thread with associated locking concerns. With the fundamental restructuring, other changes remove `synchronized` from Partition methods and instead use a `ReentrantLock` to manage the lifecycle operations of the `RebalanceTask`. The refactored approached removes the need for and use of the `BlockingSwappablePriorityQueue`, allowing the use of the standard `SwappingPriorityQueue` in the Rebalancing Partition. The approach also removes the need for the Thread-name search in the unit test, previously implemented as a stability workaround in [NIFI-16180](https://issues.apache.org/jira/browse/NIFI-16180). A new unit test also exercises the `StandardRebalancingPartition` directly to confirm expected behavior. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000` - Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000` - Pull request contains [commits signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) with a registered key indicating `Verified` status ### Pull Request Formatting - Pull Request based on current revision of the `main` branch - Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [X] Build completed using `./mvnw clean install -P contrib-check` - [X] JDK 21 - [X] JDK 25 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
