fgerlits commented on code in PR #2237:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2237#discussion_r3843230301


##########
ruff.toml:
##########
@@ -0,0 +1,15 @@
+line-length = 120
+builtins = ["log", "REL_SUCCESS", "REL_FAILURE", "REL_ORIGINAL", "raw_input"]
+
+extend-exclude = ["thirdparty",
+    "cmake-build-*",
+]

Review Comment:
   We could include "build", as that is the default build directory name used 
by the boostrap script.
   
   Also, why did the 80 -> 120 line length change move "thirdparty"? I would 
move it back to its own line.
   
   ```suggestion
   extend-exclude = [
       "thirdparty",
       "build",
       "cmake-build-*",
   ]
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to