markap14 commented on PR #11599: URL: https://github.com/apache/nifi/pull/11599#issuecomment-5470752299
Good catch, thanks @exceptionfactory. I went through the moved classes and checked (via grep across all ~500 existing \`*IT\` test classes, which live in subpackages of \`org.apache.nifi.tests.system\`) which ones are actually referenced from outside the framework's own package. \`NiFiInstanceProvider\`, \`AggregateNiFiInstance\`, \`NiFiInstanceCache\`, \`NiFiSystemKeyStoreProvider\`, and \`TroubleshootingTestWatcher\` (including the one you called out) have no external consumers - they're only used internally by \`NiFiSystemIT\` and its factory implementations, so I made them package-private in the latest commit. \`NiFiSystemIT\`, \`NiFiInstance\`, \`NiFiInstanceFactory\`, \`InstanceConfiguration\`, \`SpawnedStandaloneNiFiInstanceFactory\`, \`SpawnedClusterNiFiInstanceFactory\`, \`NiFiClientUtil\`, and \`ExceptionalBooleanSupplier\` do need to stay public - they're directly extended/constructed/imported from test classes in other packages today. Rebuilt and reran the sample IT test to confirm nothing broke. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
