exceptionfactory commented on code in PR #11562:
URL: https://github.com/apache/nifi/pull/11562#discussion_r3896927355
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java:
##########
@@ -1807,17 +1810,35 @@ private void setEffectiveParameterUpdates(final
ParameterContextDTO parameterCon
parameterDTO.setName(parameterName);
parameterEntity.setParameter(parameterDTO);
} else {
- parameterEntity =
dtoFactory.createParameterEntity(parameterContext, parameter, revisionManager,
parameterContextDAO);
+ final Parameter entityParameter = locallyOwned ?
localParameters.get(parameterDescriptor) : parameter;
Review Comment:
It looks like this introduces a discrepancy for how the parameter checking
occurs when adding inheritance. This keeps the original value and requested
value as the parameter reference `#{ParameterName}`, but that avoids triggering
any changes.
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java:
##########
@@ -1807,17 +1810,35 @@ private void setEffectiveParameterUpdates(final
ParameterContextDTO parameterCon
parameterDTO.setName(parameterName);
parameterEntity.setParameter(parameterDTO);
} else {
- parameterEntity =
dtoFactory.createParameterEntity(parameterContext, parameter, revisionManager,
parameterContextDAO);
+ final Parameter entityParameter = locallyOwned ?
localParameters.get(parameterDescriptor) : parameter;
+ parameterEntity =
dtoFactory.createParameterEntity(parameterContext, entityParameter,
revisionManager, parameterContextDAO);
Review Comment:
This appears to be a latent issue, but `createParameterEntity()` calls
`createParameterDto()`, which substitutes a hard-coded mask string when the
Parameter is marked as sensitive. This seems like it will cause issues when
persisting the values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
