lordgamez commented on code in PR #2252:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2252#discussion_r3911892547
##########
.github/workflows/create-release-artifacts.yml:
##########
@@ -93,10 +93,10 @@ jobs:
shell: cmd
working-directory: bootstrap
- name: Upload conan packages
- if: always() && ${{ inputs.enable_conan }}
+ if: always() && inputs.enable_conan
working-directory: bootstrap
run: |
- venv\Scripts\activate && conan remote login nifi-conan && conan
upload "*" -r nifi-conan --confirm
+ venv\Scripts\activate && conan remote login nifi-conan
"%CONAN_LOGIN_USERNAME_NIFI_CONAN%" -p "%CONAN_PASSWORD_NIFI_CONAN%" && conan
upload "*" -r nifi-conan --confirm
Review Comment:
According to the documentation CONAN_LOGIN_USERNAME_{REMOTE_NAME} and
CONAN_PASSWORD_{REMOTE_NAME} environment variables are automatically used to
authenticate so there should be no need to explicitly sepcify them, was this
not working before?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
