skeossei opened a new pull request, #11616: URL: https://github.com/apache/nifi/pull/11616
<!-- Licensed to the Apache Software Foundation (ASF) under one or more --> <!-- contributor license agreements. See the NOTICE file distributed with --> <!-- this work for additional information regarding copyright ownership. --> <!-- The ASF licenses this file to You under the Apache License, Version 2.0 --> <!-- (the "License"); you may not use this file except in compliance with --> <!-- the License. You may obtain a copy of the License at --> <!-- http://www.apache.org/licenses/LICENSE-2.0 --> <!-- Unless required by applicable law or agreed to in writing, software --> <!-- distributed under the License is distributed on an "AS IS" BASIS, --> <!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. --> <!-- See the License for the specific language governing permissions and --> <!-- limitations under the License. --> # Summary [NIFI-16285](https://issues.apache.org/jira/browse/NIFI-16285) NIFI-16236 / #11579 validates Parameter names so illegal names cannot be created. The same check was also applied in `VersionedFlowSynchronizer.createParameterMap`, which runs on every flow inherit, including standalone load of `flow.json.gz`. A persisted flow that already contains a legacy illegal Parameter name (for example `PARAMETER_{{ ENVIRONMENT }}`) now throws `FlowSynchronizationException` during startup, so NiFi never comes up and the REST deletion path from NIFI-16236 is unreachable. This change removes Parameter name validation from flow inherit. REST create/update still reject illegal names. Existing illegal names load so they can be deleted. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI-16285) issue created ### Pull Request Tracking - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000` - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000` - [ ] Pull request contains [commits signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) with a registered key indicating `Verified` status ### Pull Request Formatting - [x] Pull Request based on current revision of the `main` branch - [x] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `./mvnw clean install -P contrib-check` - [ ] JDK 21 - [ ] JDK 25 Focused verification using JDK 21: - `VersionedFlowSynchronizerTest#testSyncLoadsInvalidParameterName` passed - Local NiFi 2.12.0-SNAPSHOT assembly built from this branch started with a `flow.json.gz` containing `PARAMETER_{{ ENVIRONMENT }}` (`Added Parameter Context repro-context`, `Successfully synchronized dataflow`) ### Licensing - [x] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [x] New dependencies are documented in applicable `LICENSE` and `NOTICE` files No new dependencies were added, so no `LICENSE` or `NOTICE` changes are required. ### Documentation - [x] Documentation formatting appears as expected in rendered files No documentation files were changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
